Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add github.dev and gitpod.io to known hosts #822

Merged
merged 3 commits into from
Jan 18, 2024
Merged

feat: add github.dev and gitpod.io to known hosts #822

merged 3 commits into from
Jan 18, 2024

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Jan 17, 2024

Description

This PR includes github.dev and gitpod.io in the list of known HttpAgent hosts to support remote IDE development out of the box. The context for this change can be found in the internal #poc-dev-env-in-5-mins Slack channel as well as this forum conversation.

CC @chenyan-dfinity

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation. (NA)

@rvanasa rvanasa requested a review from a team as a code owner January 17, 2024 01:39
chenyan-dfinity
chenyan-dfinity approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvanasa rvanasa mentioned this pull request Jan 17, 2024
Merged
@krpeacock krpeacock merged commit 3feefc1 into dfinity:main Jan 18, 2024
15 checks passed
@rvanasa rvanasa deleted the web-ide-known-hosts branch January 18, 2024 18:25
@fxgst fxgst mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker left review comments

@chenyan-dfinity chenyan-dfinity chenyan-dfinity approved these changes

@krpeacock krpeacock krpeacock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rvanasa @krpeacock @peterpeterparker @chenyan-dfinity